Update Get-CodeOwners Logic. by chidozieononiwu · Pull Request #2093 · Azure/azure-sdk-tools

chidozieononiwu · 2021-10-12T01:03:27Z

Consume CodeOwnersParser Logic form DevOps tools repo. (Depends on Updates to Identity Resolver #2085 + plus run of the associated pipelines).
Seperate team alias from user alias. Incorporate changes originally started in https://github.com/Azure/azure-sdk-tools/pull/981/files

azure-sdk · 2021-10-12T01:08:31Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

eng/common/scripts/get-codeowners.ps1

eng/common/pipelines/templates/steps/get-pr-owners.yml

eng/common/scripts/get-codeowners.ps1

azure-sdk · 2021-10-19T21:11:09Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk · 2021-10-19T23:22:59Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

…wnerse

azure-sdk · 2021-10-20T00:46:52Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk · 2021-10-20T01:24:03Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

sima-zhu

LGTM. Java will remove the dependency on get-pr-owners.yml after check in daily update changes.
Azure/azure-sdk-for-java#24748. We can have a followup PR to output the identity json instead of github identity only.

ghost · 2021-10-20T19:08:10Z

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

weshaggard · 2021-10-20T21:42:40Z

eng/common/pipelines/templates/steps/get-pr-owners.yml

+    inputs:
+      command: custom
+      custom: 'tool'
+      arguments: 'install --global --add-source "${{ parameters.DevOpsFeed }}" --version "1.0.0-dev.20211018.1" "Azure.Sdk.Tools.IdentityResolver"'


Why are these versions different? We should pull this version into a variable and share it across both of these.

We also can consider combining these tools into one tools package.

weshaggard · 2021-10-20T21:43:44Z

eng/common/pipelines/templates/steps/get-pr-owners.yml

@@ -1,16 +1,30 @@
 parameters: 
  TargetVariable: ''
+  TargetUserVariable: 'notspecified'


These should default to empty and if they are empty then we don't write any variable.

chidozieononiwu requested a review from a team as a code owner October 12, 2021 01:03

weshaggard reviewed Oct 12, 2021

View reviewed changes

eng/common/scripts/get-codeowners.ps1 Outdated Show resolved Hide resolved

benbp reviewed Oct 12, 2021

View reviewed changes

eng/common/pipelines/templates/steps/get-pr-owners.yml Show resolved Hide resolved

benbp reviewed Oct 12, 2021

View reviewed changes

eng/common/scripts/get-codeowners.ps1 Outdated Show resolved Hide resolved

benbp reviewed Oct 12, 2021

View reviewed changes

eng/common/scripts/get-codeowners.ps1 Outdated Show resolved Hide resolved

chidozieononiwu requested review from a team and removed request for a team October 13, 2021 21:40

azure-sdk requested a review from scbedd October 13, 2021 21:46

chidozieononiwu removed the request for review from scbedd October 13, 2021 22:45

chidozieononiwu closed this Oct 19, 2021

chidozieononiwu reopened this Oct 19, 2021

chidozieononiwu force-pushed the UpdateCodeOwnersScript branch from ed6f585 to ce54242 Compare October 19, 2021 21:06

chidozieononiwu force-pushed the UpdateCodeOwnersScript branch 3 times, most recently from 0f26433 to 0132e82 Compare October 19, 2021 23:18

Consume Codeowners parser library, ceperate users from teams in codeo…

5a5fa82

…wnerse

chidozieononiwu force-pushed the UpdateCodeOwnersScript branch from 0132e82 to 1b95856 Compare October 20, 2021 00:41

chidozieononiwu force-pushed the UpdateCodeOwnersScript branch from 1b95856 to d3e20ea Compare October 20, 2021 01:19

Update get-pr-owners and related logic

d3e20ea

benbp approved these changes Oct 20, 2021

View reviewed changes

sima-zhu approved these changes Oct 20, 2021

View reviewed changes

azure-sdk added the auto-merge label Oct 20, 2021

ghost merged commit 4bfbe00 into Azure:main Oct 20, 2021

chidozieononiwu mentioned this pull request Oct 20, 2021

Extend code-owners resolution to allow teams #954

Closed

weshaggard reviewed Oct 20, 2021

View reviewed changes

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Get-CodeOwners Logic.#2093

Update Get-CodeOwners Logic.#2093
2 commits merged intoAzure:mainfrom
chidozieononiwu:UpdateCodeOwnersScript

chidozieononiwu commented Oct 12, 2021

Uh oh!

azure-sdk commented Oct 12, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-sdk commented Oct 19, 2021

Uh oh!

azure-sdk commented Oct 19, 2021

Uh oh!

azure-sdk commented Oct 20, 2021

Uh oh!

azure-sdk commented Oct 20, 2021

Uh oh!

sima-zhu left a comment

Uh oh!

ghost commented Oct 20, 2021

Uh oh!

weshaggard Oct 20, 2021

Uh oh!

weshaggard Oct 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

chidozieononiwu commented Oct 12, 2021

Uh oh!

azure-sdk commented Oct 12, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-sdk commented Oct 19, 2021

Uh oh!

azure-sdk commented Oct 19, 2021

Uh oh!

azure-sdk commented Oct 20, 2021

Uh oh!

azure-sdk commented Oct 20, 2021

Uh oh!

sima-zhu left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Oct 20, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

weshaggard Oct 20, 2021

Choose a reason for hiding this comment

Uh oh!

weshaggard Oct 20, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.